Check whether `gbs export` succeeds before remote building

Feature #1396

Change-Id: Iedfadd42d40e759dafdcb16d9d221890270b24f1

diff --git a/job_policycheck.py b/job_policycheck.py
index d3ec932..f8f90d1 100755 (executable)
--- a/job_policycheck.py
+++ b/job_policycheck.py
@@ -16,8 +16,10 @@ from common.git import Git, clone_gitproject
 from common import gerrit
 from common import mapping
 from common.tempbuildpkg import TempPackageBuild
+from common import runner
 
 from gbp.rpm import SpecFile
+from gbp.errors import GbpError
 
 def end(tmpdir, return_code = 0):
     """Get return code"""
@@ -58,6 +60,27 @@ def specfile_chooser(prjdir, packagingdir, obs_pkg, specs, prj):
 
     return specfile
 
+def export(prjdir, packagingdir, mygit, events, mygerrit):
+    """Check a git repo whether it can be executed `gbs export` correctly"""
+    mygit.checkout('FETCH_HEAD')
+    tempd = tempfile.mkdtemp(dir=packagingdir)
+    cmd = 'gbs export --packaging-dir %s -o %s' % (packagingdir, tempd)
+
+    with utils.Workdir(prjdir):
+        rcode, outs = runner.show(cmd)
+
+    shutil.rmtree(tempd)
+
+    if rcode:
+        msg = "Use 'gbs export' to generate package on this patch failed, " \
+                "please have a check.\n\n" \
+                "gbs command: %s\n" \
+                "%s" % (cmd[:cmd.rfind(' -o ')], outs)
+        mygerrit.review(events['patchset_revision'], message=msg)
+        return False
+
+    return True
+
 def build_package(obs_dest_prj, specfile, prjdir, packagingdir, events,
             mygerrit):
     """Build package in OBS"""
@@ -149,6 +172,9 @@ def main():
     # search spec file under packaging dir
     specs = utils.find_spec('%s/%s' % (prjdir, packagingdir))
 
+    if not export(prjdir, packagingdir, mygit, events, mygerrit):
+        return end(tmpdir) # not jenkins' error, return 0
+
     rc_codes = []
 
     for target in obstargets: