media: ov5693: fix returnvar.cocci warnings
authorkernel test robot <lkp@intel.com>
Wed, 19 Jan 2022 05:24:47 +0000 (06:24 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 28 Jan 2022 18:32:49 +0000 (19:32 +0100)
drivers/media/i2c/ov5693.c:953:5-8: Unneeded variable: "ret". Return "0" on line 985

 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

[Sakari Ailus: Improved subject]

CC: Daniel Scally <djrscally@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov5693.c

index 4a5aa6e..117ff54 100644 (file)
@@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
        unsigned int width, height;
        unsigned int hblank;
        int exposure_max;
-       int ret = 0;
 
        crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which);
 
@@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
        format->format = *fmt;
 
        if (format->which == V4L2_SUBDEV_FORMAT_TRY)
-               return ret;
+               return 0;
 
        mutex_lock(&ov5693->lock);
 
@@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
                                     exposure_max));
 
        mutex_unlock(&ov5693->lock);
-       return ret;
+       return 0;
 }
 
 static int ov5693_get_selection(struct v4l2_subdev *sd,