Bug 555219 – Memory leak when using pango_layout_iter_copy Patch from

2008-10-06  Behdad Esfahbod  <behdad@gnome.org>

        Bug 555219 – Memory leak when using pango_layout_iter_copy
        Patch from Falk Rohsiepe

        * pango/pango-layout.c (pango_layout_iter_copy):  Use gslice, not
        memdup.  Oops!

svn path=/trunk/; revision=2726

diff --git a/ChangeLog b/ChangeLog
index cb30321..1ba8871 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-10-06  Behdad Esfahbod  <behdad@gnome.org>
+
+       Bug 555219 – Memory leak when using pango_layout_iter_copy
+       Patch from Falk Rohsiepe
+
+       * pango/pango-layout.c (pango_layout_iter_copy):  Use gslice, not
+       memdup.  Oops!
+
 2008-09-29  Behdad Esfahbod  <behdad@gnome.org>
 
        * pango/opentype/harfbuzz-gpos.c (Position_CursiveChain):

diff --git a/pango/pango-layout.c b/pango/pango-layout.c
index 0d2f6a7..6be30bd 100644 (file)
--- a/pango/pango-layout.c
+++ b/pango/pango-layout.c
@@ -5445,8 +5445,7 @@ pango_layout_iter_copy (PangoLayoutIter *iter)
   for (l = iter->line_extents; l; l = l->next)
     {
       new->line_extents = g_slist_prepend (new->line_extents,
-                                          g_memdup (l->data,
-                                                    sizeof (Extents)));
+                              g_slice_dup (Extents, l->data));
       if (l == iter->line_extents_link)
        new->line_extents_link = new->line_extents;
     }