rtw88: fix an issue about leak system resources
authorDejin Zheng <zhengdejin5@gmail.com>
Mon, 4 May 2020 08:34:42 +0000 (16:34 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 6 May 2020 08:37:32 +0000 (11:37 +0300)
the related system resources were not released when pci_iomap() return
error in the rtw_pci_io_mapping() function. add pci_release_regions() to
fix it.

Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200504083442.3033-1-zhengdejin5@gmail.com
drivers/net/wireless/realtek/rtw88/pci.c

index 8a8d746..b9a5868 100644 (file)
@@ -1102,6 +1102,7 @@ static int rtw_pci_io_mapping(struct rtw_dev *rtwdev,
        len = pci_resource_len(pdev, bar_id);
        rtwpci->mmap = pci_iomap(pdev, bar_id, len);
        if (!rtwpci->mmap) {
+               pci_release_regions(pdev);
                rtw_err(rtwdev, "failed to map pci memory\n");
                return -ENOMEM;
        }