Staging: sbe-2t3e3: fix coding style issues in netdev.c
authorPranav Ravichandran <me@onloop.net>
Mon, 15 Oct 2012 17:38:26 +0000 (23:08 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Oct 2012 19:12:40 +0000 (12:12 -0700)
This patch fixes a POINTER_LOCATION error(changed foo* bar to foo *bar)
and an ASSIGN_IN_IF error(moved assignment out of if condition).

Signed-off-by: Pranav Ravichandran <me@onloop.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sbe-2t3e3/netdev.c

index 180c963..1f5088b 100644 (file)
@@ -57,7 +57,7 @@ static int t3e3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
        return 0;
 }
 
-static struct net_device_statst3e3_get_stats(struct net_device *dev)
+static struct net_device_stats *t3e3_get_stats(struct net_device *dev)
 {
        struct net_device_stats *nstats = &dev->stats;
        struct channel *sc = dev_to_priv(dev);
@@ -134,7 +134,8 @@ int setup_device(struct net_device *dev, struct channel *sc)
        dev->tx_queue_len = 100;
        hdlc->xmit = t3e3_if_start_xmit;
        hdlc->attach = t3e3_attach;
-       if ((retval = register_hdlc_device(dev))) {
+       retval = register_hdlc_device(dev);
+       if (retval) {
                dev_err(&sc->pdev->dev, "error registering HDLC device\n");
                return retval;
        }