cifs: Add some missing xas_retry() calls
authorDavid Howells <dhowells@redhat.com>
Thu, 23 Feb 2023 08:15:38 +0000 (08:15 +0000)
committerSteve French <stfrench@microsoft.com>
Thu, 2 Mar 2023 00:17:16 +0000 (18:17 -0600)
The xas_for_each loops added into fs/cifs/file.c need to go round again if
indicated by xas_retry().

Fixes: b8713c4dbfa3 ("cifs: Add some helper functions")
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
cc: Shyam Prasad N <nspmangalore@gmail.com>
cc: Rohith Surabattula <rohiths.msft@gmail.com>
cc: Tom Talpey <tom@talpey.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cifs@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/file.c

index ebfcaae..879524b 100644 (file)
@@ -52,6 +52,8 @@ static void cifs_undirty_folios(struct inode *inode, loff_t start, unsigned int
 
        end = (start + len - 1) / PAGE_SIZE;
        xas_for_each_marked(&xas, folio, end, PAGECACHE_TAG_DIRTY) {
+               if (xas_retry(&xas, folio))
+                       continue;
                xas_pause(&xas);
                rcu_read_unlock();
                folio_lock(folio);
@@ -81,6 +83,8 @@ void cifs_pages_written_back(struct inode *inode, loff_t start, unsigned int len
 
        end = (start + len - 1) / PAGE_SIZE;
        xas_for_each(&xas, folio, end) {
+               if (xas_retry(&xas, folio))
+                       continue;
                if (!folio_test_writeback(folio)) {
                        WARN_ONCE(1, "bad %x @%llx page %lx %lx\n",
                                  len, start, folio_index(folio), end);
@@ -112,6 +116,8 @@ void cifs_pages_write_failed(struct inode *inode, loff_t start, unsigned int len
 
        end = (start + len - 1) / PAGE_SIZE;
        xas_for_each(&xas, folio, end) {
+               if (xas_retry(&xas, folio))
+                       continue;
                if (!folio_test_writeback(folio)) {
                        WARN_ONCE(1, "bad %x @%llx page %lx %lx\n",
                                  len, start, folio_index(folio), end);