Remove two failing WebKitAPITest tests
authoraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Sep 2011 12:15:28 +0000 (12:15 +0000)
committeraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Sep 2011 12:15:28 +0000 (12:15 +0000)
The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.

Reviewed by Anders Carlsson.

* WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
MainFrameAfterClose tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/WebKitAPITest/tests/WebViewDestruction.cpp

index c990529..b904f1b 100644 (file)
@@ -1,3 +1,14 @@
+2011-09-23  Adam Roben  <aroben@apple.com>
+
+        Remove two failing WebKitAPITest tests
+
+        The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
+
+        Reviewed by Anders Carlsson.
+
+        * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
+        MainFrameAfterClose tests.
+
 2011-09-25  Adam Barth  <abarth@webkit.org>
 
         Finish removing PLATFORM(BREWMP) by removing associated code
index b7ae0b6..4ab3a6a 100644 (file)
@@ -114,17 +114,6 @@ TEST(WebViewDestruction, CloseWithoutInitWithFrame)
     finishWebViewDestructionTest(webView, 0);
 }
 
-// Tests that releasing a WebView without calling IWebView::close or DestroyWindow doesn't leak. <http://webkit.org/b/33162>
-TEST(WebViewDestruction, NoCloseOrDestroyViewWindow)
-{
-    COMPtr<IWebView> webView;
-    HostWindow window;
-    HWND viewWindow;
-    createAndInitializeWebView(webView, window, viewWindow);
-
-    finishWebViewDestructionTest(webView, viewWindow);
-}
-
 // Tests that calling IWebView::close without calling DestroyWindow, then releasing a WebView doesn't crash. <http://webkit.org/b/32827>
 TEST(WebViewDestruction, CloseWithoutDestroyViewWindow)
 {
@@ -214,19 +203,4 @@ TEST(WebViewDestruction, CloseThenDestroyHostWindow)
     finishWebViewDestructionTest(webView, viewWindow);
 }
 
-// Tests that calling IWebView::mainFrame after calling IWebView::close doesn't crash. <http://webkit.org/b/32868>
-TEST(WebViewDestruction, MainFrameAfterClose)
-{
-    COMPtr<IWebView> webView;
-    HostWindow window;
-    HWND viewWindow;
-    createAndInitializeWebView(webView, window, viewWindow);
-
-    TEST_ASSERT(SUCCEEDED(webView->close()));
-    COMPtr<IWebFrame> mainFrame;
-    TEST_ASSERT(SUCCEEDED(webView->mainFrame(&mainFrame)));
-
-    finishWebViewDestructionTest(webView, viewWindow);
-}
-
 } // namespace WebKitAPITest