intel_th: Consistency and off-by-one fix
authorPavel Machek <pavel@ucw.cz>
Wed, 14 Apr 2021 17:12:49 +0000 (20:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Apr 2021 05:26:50 +0000 (07:26 +0200)
Consistently use "< ... +1" in for loops.

Fix of-by-one in for_each_set_bit().

Signed-off-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Link: https://lore.kernel.org/lkml/20190724095841.GA6952@amd/
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210414171251.14672-6-alexander.shishkin@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/intel_th/gth.c

index f72803a..28509b0 100644 (file)
@@ -543,7 +543,7 @@ static void intel_th_gth_disable(struct intel_th_device *thdev,
        output->active = false;
 
        for_each_set_bit(master, gth->output[output->port].master,
-                        TH_CONFIGURABLE_MASTERS) {
+                        TH_CONFIGURABLE_MASTERS + 1) {
                gth_master_set(gth, master, -1);
        }
        spin_unlock(&gth->gth_lock);
@@ -697,7 +697,7 @@ static void intel_th_gth_unassign(struct intel_th_device *thdev,
        othdev->output.port = -1;
        othdev->output.active = false;
        gth->output[port].output = NULL;
-       for (master = 0; master <= TH_CONFIGURABLE_MASTERS; master++)
+       for (master = 0; master < TH_CONFIGURABLE_MASTERS + 1; master++)
                if (gth->master[master] == port)
                        gth->master[master] = -1;
        spin_unlock(&gth->gth_lock);