projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2219c9e
)
drm/nouveau/dmem: Fix a NULL vs IS_ERR() check
author
Dan Carpenter
<dan.carpenter@oracle.com>
Fri, 22 Feb 2019 06:34:04 +0000
(09:34 +0300)
committer
Ben Skeggs
<bskeggs@redhat.com>
Thu, 21 Mar 2019 23:57:58 +0000
(09:57 +1000)
The hmm_devmem_add() function doesn't return NULL, it returns error
pointers.
Fixes:
5be73b690875
("drm/nouveau/dmem: device memory helpers for SVM")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_dmem.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/nouveau/nouveau_dmem.c
b/drivers/gpu/drm/nouveau/nouveau_dmem.c
index
58b4cb3
..
b1df42f
100644
(file)
--- a/
drivers/gpu/drm/nouveau/nouveau_dmem.c
+++ b/
drivers/gpu/drm/nouveau/nouveau_dmem.c
@@
-621,7
+621,7
@@
nouveau_dmem_init(struct nouveau_drm *drm)
*/
drm->dmem->devmem = hmm_devmem_add(&nouveau_dmem_devmem_ops,
device, size);
- if (
drm->dmem->devmem == NULL
) {
+ if (
IS_ERR(drm->dmem->devmem)
) {
kfree(drm->dmem);
drm->dmem = NULL;
return;