Bugfix: watchFile, unwatch, watch causes error

Fixed bug that caused application to cast a "TypeError: Cannot call method
'addListener' of undefined" when first watching a file, unwatching and then
watching same file again.

diff --git a/lib/fs.js b/lib/fs.js
index f9fc33999b67436802920625b8700958279ce474..22dba6dc60137014819505c06f97f03b684014de 100644 (file)
--- a/lib/fs.js
+++ b/lib/fs.js
@@ -319,7 +319,7 @@ exports.watchFile = function (filename) {
   if (options.persistent === undefined) options.persistent = true;
   if (options.interval === undefined) options.interval = 0;
 
-  if (filename in statWatchers) {
+  if (statWatchers[filename]) {
     stat = statWatchers[filename];
   } else {
     statWatchers[filename] = new fs.StatWatcher();
@@ -331,7 +331,7 @@ exports.watchFile = function (filename) {
 };
 
 exports.unwatchFile = function (filename) {
-  if (filename in statWatchers) {
+  if (statWatchers[filename]) {
     stat = statWatchers[filename];
     stat.stop();
     statWatchers[filename] = undefined;

diff --git a/test/pummel/test-watch-file.js b/test/pummel/test-watch-file.js
index aaef2da7f491845eb8a5375ea53017c4db6972be..3f50714149c4b313f326aab3eb4b5516e2da119d 100644 (file)
--- a/test/pummel/test-watch-file.js
+++ b/test/pummel/test-watch-file.js
@@ -9,12 +9,18 @@ var f2 = path.join(fixturesDir, "x2.txt");
 puts("watching for changes of " + f);
 
 var changes = 0;
-fs.watchFile(f, function (curr, prev) {
-  puts(f + " change");
-  changes++;
-  assert.ok(curr.mtime != prev.mtime);
-  fs.unwatchFile(f);
-});
+function watchFile () {
+  fs.watchFile(f, function (curr, prev) {
+    puts(f + " change");
+    changes++;
+    assert.ok(curr.mtime != prev.mtime);
+    fs.unwatchFile(f);
+    watchFile();
+    fs.unwatchFile(f);
+  });
+}
+
+watchFile();
 
 
 var fd = fs.openSync(f, "w+");