net: davinci_emac: use nvmem_get_mac_address()
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 30 Nov 2018 08:21:00 +0000 (09:21 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Dec 2018 23:40:30 +0000 (15:40 -0800)
All DaVinci boards still supported in board files now define nvmem
cells containing the MAC address. We want to stop using the setup
callback from at24 so the MAC address for those users will no longer
be provided over platform data. If we didn't get a valid MAC in pdata,
try nvmem before resorting to a random MAC.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_emac.c

index 9153db1..8408204 100644 (file)
@@ -1912,11 +1912,15 @@ static int davinci_emac_probe(struct platform_device *pdev)
                ether_addr_copy(ndev->dev_addr, priv->mac_addr);
 
        if (!is_valid_ether_addr(priv->mac_addr)) {
-               /* Use random MAC if none passed */
-               eth_hw_addr_random(ndev);
-               memcpy(priv->mac_addr, ndev->dev_addr, ndev->addr_len);
-               dev_warn(&pdev->dev, "using random MAC addr: %pM\n",
-                                                       priv->mac_addr);
+               /* Try nvmem if MAC wasn't passed over pdata or DT. */
+               rc = nvmem_get_mac_address(&pdev->dev, priv->mac_addr);
+               if (rc) {
+                       /* Use random MAC if still none obtained. */
+                       eth_hw_addr_random(ndev);
+                       memcpy(priv->mac_addr, ndev->dev_addr, ndev->addr_len);
+                       dev_warn(&pdev->dev, "using random MAC addr: %pM\n",
+                                priv->mac_addr);
+               }
        }
 
        ndev->netdev_ops = &emac_netdev_ops;