check for bad params sent to discrete patheffect
authorreed <reed@chromium.org>
Sun, 3 Apr 2016 01:40:40 +0000 (18:40 -0700)
committerCommit bot <commit-bot@chromium.org>
Sun, 3 Apr 2016 01:40:40 +0000 (18:40 -0700)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853953002

TBR=

Review URL: https://codereview.chromium.org/1853953002

src/effects/SkDiscretePathEffect.cpp

index 5af6ab4..1c6039c 100644 (file)
 
 sk_sp<SkPathEffect> SkDiscretePathEffect::Make(SkScalar segLength, SkScalar deviation,
                                                uint32_t seedAssist) {
+    if (!SkScalarIsFinite(segLength) || !SkScalarIsFinite(deviation)) {
+        return nullptr;
+    }
+    if (segLength <= SK_ScalarNearlyZero) {
+        return nullptr;
+    }
     return sk_sp<SkPathEffect>(new SkDiscretePathEffect(segLength, deviation, seedAssist));
 }