assrender: Do not iterate over mimetypes without filename
authorRafał Dzięgiel <rafostar.github@gmail.com>
Wed, 20 Jan 2021 12:38:03 +0000 (13:38 +0100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 21 Oct 2021 22:21:40 +0000 (22:21 +0000)
No point spending time on iterating and comparing strings if we
are going to reject the value due to missing filename anyway.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>

subprojects/gst-plugins-bad/ext/assrender/gstassrender.c

index 64c796e..51c7987 100644 (file)
@@ -1572,6 +1572,10 @@ gst_ass_render_handle_tag_sample (GstAssRender * render, GstSample * sample)
   if (!buf || !structure)
     return;
 
+  filename = gst_structure_get_string (structure, "filename");
+  if (!filename)
+    return;
+
   valid_mimetype = FALSE;
   valid_extension = FALSE;
 
@@ -1585,10 +1589,6 @@ gst_ass_render_handle_tag_sample (GstAssRender * render, GstSample * sample)
     }
   }
 
-  filename = gst_structure_get_string (structure, "filename");
-  if (!filename)
-    return;
-
   if (!valid_mimetype) {
     guint len = strlen (filename);
     const gchar *extension = filename + len - 4;