iwlwifi: fix the ALIVE notification layout
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Tue, 7 Nov 2017 21:54:17 +0000 (23:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 Nov 2018 13:52:41 +0000 (14:52 +0100)
[ Upstream commit 5cd2d8fc6c6bca979ac5dd8ad0e41153f1f982f9 ]

The ucode_major and ucode_minor were swapped. This has
no practical consequences since those fields are not used.
Same goes for umac_major and umac_minor which were only
printed under certain debug flags.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/fw/api/alive.h

index 3684a3e..007bfe7 100644 (file)
@@ -95,8 +95,8 @@ enum {
 #define IWL_ALIVE_FLG_RFKILL   BIT(0)
 
 struct iwl_lmac_alive {
-       __le32 ucode_minor;
        __le32 ucode_major;
+       __le32 ucode_minor;
        u8 ver_subtype;
        u8 ver_type;
        u8 mac;
@@ -113,8 +113,8 @@ struct iwl_lmac_alive {
 } __packed; /* UCODE_ALIVE_NTFY_API_S_VER_3 */
 
 struct iwl_umac_alive {
-       __le32 umac_minor;              /* UMAC version: minor */
        __le32 umac_major;              /* UMAC version: major */
+       __le32 umac_minor;              /* UMAC version: minor */
        __le32 error_info_addr;         /* SRAM address for UMAC error log */
        __le32 dbg_print_buff_addr;
 } __packed; /* UMAC_ALIVE_DATA_API_S_VER_2 */