Marvell Sky2 Ethernet adapter: fix warning messages.
authorKrzysztof Halasa <khalasa@piap.pl>
Thu, 18 Feb 2021 12:34:42 +0000 (13:34 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Feb 2021 20:17:21 +0000 (12:17 -0800)
sky2.c driver uses netdev_warn() before the net device is initialized.
Fix it by using dev_warn() instead.

Signed-off-by: Krzysztof Halasa <khalasa@piap.pl>
Link: https://lore.kernel.org/r/m3a6s1r1ul.fsf@t19.piap.pl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/sky2.c

index ebe1406c6e64821f26e9f025d9ce8f01b0f74c42..dbec8e187a6821558b5bf8373364eeb3487bf06d 100644 (file)
@@ -4806,12 +4806,11 @@ static struct net_device *sky2_init_netdev(struct sky2_hw *hw, unsigned port,
        if (!is_valid_ether_addr(dev->dev_addr)) {
                struct sockaddr sa = { AF_UNSPEC };
 
-               netdev_warn(dev,
-                           "Invalid MAC address, defaulting to random\n");
+               dev_warn(&hw->pdev->dev, "Invalid MAC address, defaulting to random\n");
                eth_hw_addr_random(dev);
                memcpy(sa.sa_data, dev->dev_addr, ETH_ALEN);
                if (sky2_set_mac_address(dev, &sa))
-                       netdev_warn(dev, "Failed to set MAC address.\n");
+                       dev_warn(&hw->pdev->dev, "Failed to set MAC address.\n");
        }
 
        return dev;