projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
724376c
)
soc: qcom: ocmem: Fix missing put_device() call in of_get_ocmem
author
Miaoqian Lin
<linmq006@gmail.com>
Fri, 7 Jan 2022 07:31:26 +0000
(07:31 +0000)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:15 +0000
(14:23 +0200)
[ Upstream commit
0ff027027e05a866491bbb53494f0e2a61354c85
]
The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.
Fixes: 01f937ffc468 ("soc: qcom: ocmem: don't return NULL in of_get_ocmem")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link:
https://lore.kernel.org/r/20220107073126.2335-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/qcom/ocmem.c
patch
|
blob
|
history
diff --git
a/drivers/soc/qcom/ocmem.c
b/drivers/soc/qcom/ocmem.c
index f1875dc31ae2cb8991e98a3a28e6b52fcd5405a9..85f82e195ef8b7115536ea852a7fafd94cd1a3d2 100644
(file)
--- a/
drivers/soc/qcom/ocmem.c
+++ b/
drivers/soc/qcom/ocmem.c
@@
-206,6
+206,7
@@
struct ocmem *of_get_ocmem(struct device *dev)
ocmem = platform_get_drvdata(pdev);
if (!ocmem) {
dev_err(dev, "Cannot get ocmem\n");
+ put_device(&pdev->dev);
return ERR_PTR(-ENODEV);
}
return ocmem;