serial: core: Drop duplicate NULL check in uart_*shutdown()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 4 Feb 2022 15:28:08 +0000 (17:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Feb 2022 15:58:59 +0000 (16:58 +0100)
The free_page(addr), which becomes free_pages(addr, 0) checks addr
against 0. No need to repeat this check in the callers.

Acked-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220204152808.10808-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/serial_core.c

index ba4baa7..846192a 100644 (file)
@@ -317,8 +317,7 @@ static void uart_shutdown(struct tty_struct *tty, struct uart_state *state)
        state->xmit.buf = NULL;
        uart_port_unlock(uport, flags);
 
-       if (xmit_buf)
-               free_page((unsigned long)xmit_buf);
+       free_page((unsigned long)xmit_buf);
 }
 
 /**
@@ -1569,8 +1568,7 @@ static void uart_tty_port_shutdown(struct tty_port *port)
        state->xmit.buf = NULL;
        spin_unlock_irq(&uport->lock);
 
-       if (buf)
-               free_page((unsigned long)buf);
+       free_page((unsigned long)buf);
 
        uart_change_pm(state, UART_PM_STATE_OFF);
 }