iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler()
authorNathan Chancellor <nathan@kernel.org>
Thu, 24 Feb 2022 21:10:34 +0000 (14:10 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 26 Feb 2022 18:07:10 +0000 (18:07 +0000)
Clang warns:

  drivers/iio/accel/adxl367.c:887:2: error: variable 'handled' is uninitialized when used here [-Werror,-Wuninitialized]
          handled |= adxl367_push_event(indio_dev, status);
          ^~~~~~~
  drivers/iio/accel/adxl367.c:879:14: note: initialize the variable 'handled' to silence this warning
          bool handled;
                      ^
                       = 0
  1 error generated.

This should have used '=' instead of '|='; make that change to resolve
the warning.

Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1605
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220224211034.625130-1-nathan@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/adxl367.c

index bdc95409abed95573163b1ca3e122a36c5e4eb37..62960134ea195532c42dc765ab64fa5165b7f6f4 100644 (file)
@@ -884,7 +884,7 @@ static irqreturn_t adxl367_irq_handler(int irq, void *private)
        if (ret)
                return IRQ_NONE;
 
-       handled |= adxl367_push_event(indio_dev, status);
+       handled = adxl367_push_event(indio_dev, status);
        handled |= adxl367_push_fifo_data(indio_dev, status, fifo_entries);
 
        return handled ? IRQ_HANDLED : IRQ_NONE;