debugfs: lockdown: Allow reading debugfs files that are not world readable
authorMichal Suchanek <msuchanek@suse.de>
Tue, 4 Jan 2022 17:05:05 +0000 (18:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:55 +0000 (11:03 +0100)
[ Upstream commit 358fcf5ddbec4e6706405847d6a666f5933a6c25 ]

When the kernel is locked down the kernel allows reading only debugfs
files with mode 444. Mode 400 is also valid but is not allowed.

Make the 444 into a mask.

Fixes: 5496197f9b08 ("debugfs: Restrict debugfs when the kernel is locked down")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Link: https://lore.kernel.org/r/20220104170505.10248-1-msuchanek@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/debugfs/file.c

index 7d162b0..950c63f 100644 (file)
@@ -147,7 +147,7 @@ static int debugfs_locked_down(struct inode *inode,
                               struct file *filp,
                               const struct file_operations *real_fops)
 {
-       if ((inode->i_mode & 07777) == 0444 &&
+       if ((inode->i_mode & 07777 & ~0444) == 0 &&
            !(filp->f_mode & FMODE_WRITE) &&
            !real_fops->unlocked_ioctl &&
            !real_fops->compat_ioctl &&