thermal: exynos: remove trip reporting to user-space 82/216482/1 submit/tizen/20191031.012258
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Thu, 26 Apr 2018 11:51:33 +0000 (13:51 +0200)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 25 Oct 2019 09:30:19 +0000 (18:30 +0900)
Remove trip reporting to user-space - I'm not aware of any user-space
program which relies on it and there is a thermal user-space governor
which does it in proper way nowadays.

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
[sw0312.kim: apply mainline commit b43e3cfe232a to remove unnecessary overhead uevent]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I618b1c0c2285f823ecad527b76d38153068a6d32

drivers/thermal/samsung/exynos_tmu.c

index d60069b..0918cf2 100644 (file)
@@ -215,33 +215,6 @@ struct exynos_tmu_data {
        void (*tmu_clear_irqs)(struct exynos_tmu_data *data);
 };
 
-static void exynos_report_trigger(struct exynos_tmu_data *p)
-{
-       char data[10], *envp[] = { data, NULL };
-       struct thermal_zone_device *tz = p->tzd;
-       int temp;
-       unsigned int i;
-
-       if (!tz) {
-               pr_err("No thermal zone device defined\n");
-               return;
-       }
-
-       thermal_zone_device_update(tz, THERMAL_EVENT_UNSPECIFIED);
-
-       mutex_lock(&tz->lock);
-       /* Find the level for which trip happened */
-       for (i = 0; i < of_thermal_get_ntrips(tz); i++) {
-               tz->ops->get_trip_temp(tz, i, &temp);
-               if (tz->last_temperature < temp)
-                       break;
-       }
-
-       snprintf(data, sizeof(data), "%u", i);
-       kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, envp);
-       mutex_unlock(&tz->lock);
-}
-
 /*
  * TMU treats temperature as a mapped temperature code.
  * The temperature is converted differently depending on the calibration type.
@@ -1042,7 +1015,8 @@ static void exynos_tmu_work(struct work_struct *work)
        if (!IS_ERR(data->clk_sec))
                clk_disable(data->clk_sec);
 
-       exynos_report_trigger(data);
+       thermal_zone_device_update(data->tzd, THERMAL_EVENT_UNSPECIFIED);
+
        mutex_lock(&data->lock);
        clk_enable(data->clk);