elementary: Fix resource leak
authorChris Michael <cp.michael@samsung.com>
Mon, 11 Dec 2017 19:47:14 +0000 (14:47 -0500)
committerChris Michael <cp.michael@samsung.com>
Mon, 11 Dec 2017 19:47:14 +0000 (14:47 -0500)
Coverity reports a resource leak here. According to eina_strbuf
documentation, the result of eina_strbuf_release should be free'd when
not needed anymore.

Fixes Coverity CID1383549

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
src/lib/elementary/efl_ui_panes.c

index b98a1ee..f215387 100644 (file)
@@ -390,18 +390,22 @@ _efl_ui_panes_efl_canvas_group_group_add(Eo *obj, Efl_Ui_Panes_Data *_pd EINA_UN
 {
    ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd);
    EFL_UI_PANES_DATA_GET(obj, sd);
+   char *group;
 
    if (!elm_widget_theme_klass_get(obj))
      elm_widget_theme_klass_set(obj, "panes");
    efl_canvas_group_add(efl_super(obj, MY_CLASS));
    elm_widget_sub_object_parent_add(obj);
 
+   group = _efl_ui_panes_theme_group_get(obj, sd);
    if (!elm_widget_theme_object_set(obj, wd->resize_obj,
                                        elm_widget_theme_klass_get(obj),
-                                       _efl_ui_panes_theme_group_get(obj, sd),
+                                       group,
                                        elm_widget_theme_style_get(obj)))
      CRI("Failed to set layout!");
 
+   free(group);
+
    elm_panes_content_left_size_set(obj, 0.5);
 
    edje_object_signal_callback_add