v4l2object: fix caps leak
authorGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Wed, 18 May 2016 09:12:15 +0000 (12:12 +0300)
committerNicolas Dufresne <nicolas.dufresne@collabora.com>
Wed, 25 May 2016 17:40:54 +0000 (13:40 -0400)
gst_v4l2_object_probe_caps() was taking an extra ref on the returned
caps for no reason.

https://bugzilla.gnome.org/show_bug.cgi?id=766610

sys/v4l2/gstv4l2object.c

index da83d08..05258ca 100644 (file)
@@ -3867,9 +3867,11 @@ gst_v4l2_object_probe_caps (GstV4l2Object * v4l2object, GstCaps * filter)
   }
 
   if (filter) {
+    GstCaps *tmp;
+
+    tmp = ret;
     ret = gst_caps_intersect_full (filter, ret, GST_CAPS_INTERSECT_FIRST);
-  } else {
-    ret = gst_caps_ref (ret);
+    gst_caps_unref (tmp);
   }
 
   return ret;