ACPICA: Improve warning message for "invalid ACPI name"
authorBob Moore <robert.moore@intel.com>
Thu, 27 Oct 2022 17:55:26 +0000 (19:55 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 28 Oct 2022 15:28:23 +0000 (17:28 +0200)
ACPICA commit 91bef8bea9cd69c33447ba1bfe2c4273994500fd

Added an underscore instead of an (illegal) *

Link: https://github.com/acpica/acpica/commit/91bef8be
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpica/utstring.c

index c39b548..aae71b8 100644 (file)
@@ -145,7 +145,7 @@ void acpi_ut_repair_name(char *name)
                return;
        }
 
-       ACPI_COPY_NAMESEG(&original_name, name);
+       ACPI_COPY_NAMESEG(&original_name, &name[0]);
 
        /* Check each character in the name */
 
@@ -156,10 +156,10 @@ void acpi_ut_repair_name(char *name)
 
                /*
                 * Replace a bad character with something printable, yet technically
-                * still invalid. This prevents any collisions with existing "good"
+                * "odd". This prevents any collisions with existing "good"
                 * names in the namespace.
                 */
-               name[i] = '*';
+               name[i] = '_';
                found_bad_char = TRUE;
        }
 
@@ -169,8 +169,8 @@ void acpi_ut_repair_name(char *name)
 
                if (!acpi_gbl_enable_interpreter_slack) {
                        ACPI_WARNING((AE_INFO,
-                                     "Invalid character(s) in name (0x%.8X), repaired: [%4.4s]",
-                                     original_name, name));
+                                     "Invalid character(s) in name (0x%.8X) %p, repaired: [%4.4s]",
+                                     original_name, name, &name[0]));
                } else {
                        ACPI_DEBUG_PRINT((ACPI_DB_INFO,
                                          "Invalid character(s) in name (0x%.8X), repaired: [%4.4s]",