fsi: master-ast-cf: Fix missing of_node_put in fsi_master_acf_probe
authorLv Ruyi <lv.ruyi@zte.com.cn>
Thu, 7 Apr 2022 08:59:11 +0000 (08:59 +0000)
committerJoel Stanley <joel@jms.id.au>
Wed, 28 Sep 2022 11:40:57 +0000 (21:10 +0930)
of_parse_phandle returns node pointer with refcount incremented, use
of_node_put() on it when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220407085911.2491719-1-lv.ruyi@zte.com.cn
Signed-off-by: Joel Stanley <joel@jms.id.au>
drivers/fsi/fsi-master-ast-cf.c

index 24292ac..5f608ef 100644 (file)
@@ -1324,12 +1324,14 @@ static int fsi_master_acf_probe(struct platform_device *pdev)
                }
                master->cvic = devm_of_iomap(&pdev->dev, np, 0, NULL);
                if (IS_ERR(master->cvic)) {
+                       of_node_put(np);
                        rc = PTR_ERR(master->cvic);
                        dev_err(&pdev->dev, "Error %d mapping CVIC\n", rc);
                        goto err_free;
                }
                rc = of_property_read_u32(np, "copro-sw-interrupts",
                                          &master->cvic_sw_irq);
+               of_node_put(np);
                if (rc) {
                        dev_err(&pdev->dev, "Can't find coprocessor SW interrupt\n");
                        goto err_free;