ARM: dts; gta04: SPI panel chip select is active low
authorH. Nikolaus Schaller <hns@goldelico.com>
Wed, 23 Dec 2020 10:30:21 +0000 (11:30 +0100)
committerTony Lindgren <tony@atomide.com>
Wed, 30 Dec 2020 08:48:07 +0000 (10:48 +0200)
With the arrival of

commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors")

it was clarified what the proper state for cs-gpios should be, even if the
flag is ignored. The driver code is doing the right thing since

766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high;
attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for
the client device description to be fully consistent.

Fixes: 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
CC: stable@vger.kernel.org
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/boot/dts/omap3-gta04.dtsi

index 003202d..7b8c18e 100644 (file)
                gpio-sck = <&gpio1 12 GPIO_ACTIVE_HIGH>;
                gpio-miso = <&gpio1 18 GPIO_ACTIVE_HIGH>;
                gpio-mosi = <&gpio1 20 GPIO_ACTIVE_HIGH>;
-               cs-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
+               cs-gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
                num-chipselects = <1>;
 
                /* lcd panel */