Fix a case where initialisation fails without setting
the passed-in GError and the caller assumes it will be
set, and add a guard to catch the condition in case it
happens again in the future.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/217>
_init_formatter_assets ();
if (!_ges_uri_asset_ensure_setup (uriasset_klass)) {
GST_ERROR ("cannot setup uri asset");
+ if (error)
+ *error = g_error_new (GST_CORE_ERROR, GST_CORE_ERROR_MISSING_PLUGIN,
+ "Cannot initialize URI asset class.");
goto failed;
}
gst_init (&argc, arguments);
if (!ges_launcher_parse_options (self, arguments, &argc, ctx, &error)) {
gst_init (NULL, NULL);
- ges_printerr ("Error initializing: %s\n", error->message);
g_option_context_free (ctx);
- g_error_free (error);
+ if (error) {
+ ges_printerr ("Error initializing: %s\n", error->message);
+ g_error_free (error);
+ } else {
+ ges_printerr ("Error parsing command line arguments\n");
+ }
*exit_status = 1;
goto done;
}