ice: add needed PFR during driver unload
authorBruce Allan <bruce.w.allan@intel.com>
Fri, 2 Aug 2019 08:25:29 +0000 (01:25 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 3 Sep 2019 23:18:52 +0000 (16:18 -0700)
According to the specification, a PF Reset must be done as part of the
driver unload flow.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c

index b62c01c..8217b81 100644 (file)
@@ -2638,6 +2638,11 @@ static void ice_remove(struct pci_dev *pdev)
        ice_deinit_pf(pf);
        ice_deinit_hw(&pf->hw);
        ice_clear_interrupt_scheme(pf);
+       /* Issue a PFR as part of the prescribed driver unload flow.  Do not
+        * do it via ice_schedule_reset() since there is no need to rebuild
+        * and the service task is already stopped.
+        */
+       ice_reset(&pf->hw, ICE_RESET_PFR);
        pci_disable_pcie_error_reporting(pdev);
 }