media: smiapp: unlock on error in smiapp_start_streaming()

We added two new error paths to smiapp_start_streaming(), but we can't
return directly without dropping the "sensor->mutex" lock.

Fixes: f8c4352c1bef ("media: smiapp: Move binning configuration to streaming start")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
index 77dfce7c3be9bacfef515dd1f3bb587e4eef5e26..84f9771b5fed0e06c3c5bdb426f12ca9cb98512e 100644 (file)
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -1362,13 +1362,13 @@ static int smiapp_start_streaming(struct smiapp_sensor *sensor)
                rval = smiapp_write(
                        sensor, SMIAPP_REG_U8_BINNING_TYPE, binning_type);
                if (rval < 0)
-                       return rval;
+                       goto out;
 
                binning_mode = 1;
        }
        rval = smiapp_write(sensor, SMIAPP_REG_U8_BINNING_MODE, binning_mode);
        if (rval < 0)
-               return rval;
+               goto out;
 
        /* Set up PLL */
        rval = smiapp_pll_configure(sensor);