webrtc_source_private: Set picture-id-mode in case of VP8 payloader 47/311747/4 accepted/tizen/unified/20240621.010426 accepted/tizen/unified/dev/20240701.072812 accepted/tizen/unified/toolchain/20240624.121526 accepted/tizen/unified/x/20240624.031944 accepted/tizen/unified/x/asan/20240625.092607
authorSangchul Lee <sc11.lee@samsung.com>
Mon, 27 May 2024 06:40:10 +0000 (15:40 +0900)
committerSangchul Lee <sc11.lee@samsung.com>
Tue, 18 Jun 2024 07:39:36 +0000 (16:39 +0900)
7-bit picture id has been set to vp8 payloader.
It has also been verified with Chrome browser.

[Version] 1.1.4
[Issue Type] Compatibility

Change-Id: Ib05694631fbb1424ba0c21194f103e94b9484f24
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
packaging/capi-media-webrtc.spec
src/webrtc_source_private.c

index e82470b52812ffdd3a0e8c5a33001987d047bb8a..7050e31da2b3c40b04895eb8d2bfdf4b241c8dfa 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    1.1.3
+Version:    1.1.4
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index c871ba5e3c9986c2bf192eb6a28921b400ac5186..1035e1008ed262f78355eb4eda99eaf63c2f4fa6 100644 (file)
@@ -978,6 +978,15 @@ skip_encoder:
        if (!source->av[idx].payloader_factory_name) {
                GstElementFactory *factory = gst_element_get_factory(payloader);
                source->av[idx].payloader_factory_name = g_strdup(GST_OBJECT_NAME(factory));
+               if (!g_strcmp0(source->av[idx].payloader_factory_name, "rtpvp8pay")) {
+                       /* NOTE: picture-id-mode has been set for compatibility with mediasoup.*/
+                       #define VP8_PAYLOADER_7BIT_PICTURE_ID 1 /* 7-bit Picture ID */
+                       g_object_set(G_OBJECT(payloader),
+                               "picture-id-mode", VP8_PAYLOADER_7BIT_PICTURE_ID,
+                               NULL);
+                       LOG_DEBUG("[%s] set picture-id-mode [%d]",
+                               source->av[idx].payloader_factory_name, VP8_PAYLOADER_7BIT_PICTURE_ID);
+               }
        }
 
        if (!is_simulcast) {