drm/vc4: For DPI, MEDIA_BUS_FMT_RGB565_1X16 is mode 1, not 3.
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Mon, 14 Feb 2022 15:34:51 +0000 (15:34 +0000)
committerDom Cobley <popcornmix@gmail.com>
Mon, 21 Mar 2022 16:04:42 +0000 (16:04 +0000)
The mapping is incorrect for RGB565_1X16 as it should be
DPI_FORMAT_18BIT_666_RGB_1 instead of DPI_FORMAT_18BIT_666_RGB_3.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/gpu/drm/vc4/vc4_dpi.c

index 0d4fb68..1bf1a4c 100644 (file)
@@ -188,7 +188,7 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
                                                       DPI_ORDER);
                                break;
                        case MEDIA_BUS_FMT_RGB565_1X16:
-                               dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3,
+                               dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1,
                                                       DPI_FORMAT);
                                break;
                        case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: