power: supply: axp20x_usb_power: Add missing check in axp20x_usb_power_probe
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Wed, 3 Mar 2021 12:12:36 +0000 (20:12 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Mon, 15 Mar 2021 00:07:54 +0000 (01:07 +0100)
There are two regmap_update_bits() calls but only one of them has
return value check, which is odd. Add a return value check and
terminate the execution flow on failure just like the other call.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/axp20x_usb_power.c

index 8933ae2..7ed76ee 100644 (file)
@@ -614,8 +614,10 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
 
        if (power->axp20x_id == AXP813_ID) {
                /* Enable USB Battery Charging specification detection */
-               regmap_update_bits(axp20x->regmap, AXP288_BC_GLOBAL,
+               ret = regmap_update_bits(axp20x->regmap, AXP288_BC_GLOBAL,
                                   AXP813_BC_EN, AXP813_BC_EN);
+               if (ret)
+                       return ret;
        }
 
        psy_cfg.of_node = pdev->dev.of_node;