projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e8b58d6
)
drm/v3d: Checking for NULL vs IS_ERR()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Fri, 18 May 2018 08:10:41 +0000
(11:10 +0300)
committer
Eric Anholt
<eric@anholt.net>
Mon, 21 May 2018 17:44:33 +0000
(10:44 -0700)
The v3d_fence_create() only returns error pointers on error. It never
returns NULL.
Fixes:
57692c94dcbe
("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link:
https://patchwork.freedesktop.org/patch/msgid/20180518081041.GC28335@mwanda
drivers/gpu/drm/v3d/v3d_sched.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/v3d/v3d_sched.c
b/drivers/gpu/drm/v3d/v3d_sched.c
index
b07bece
..
808bc90
100644
(file)
--- a/
drivers/gpu/drm/v3d/v3d_sched.c
+++ b/
drivers/gpu/drm/v3d/v3d_sched.c
@@
-114,8
+114,8
@@
static struct dma_fence *v3d_job_run(struct drm_sched_job *sched_job)
v3d_invalidate_caches(v3d);
fence = v3d_fence_create(v3d, q);
- if (
!fence
)
- return
fence
;
+ if (
IS_ERR(fence)
)
+ return
NULL
;
if (job->done_fence)
dma_fence_put(job->done_fence);