staging: kpc2000: kpc_spi: remove unnecessary cast in [read|write]_reg()
authorGeordan Neukum <gneukum1@gmail.com>
Wed, 5 Jun 2019 01:09:13 +0000 (01:09 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Jun 2019 13:05:02 +0000 (15:05 +0200)
The kpc_spi driver unnecessarily casts from a (u64 __iomem *) to a (void
*) when invoking readq and writeq which both take a (void __iomem *) arg.
There is no need for this cast, and it actually harms us by discarding
the sparse cookie, __iomem. Make the driver stop performing this casting
operation.

Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_spi.c

index 4f517af..28132e9 100644 (file)
@@ -167,7 +167,7 @@ kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx)
        if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)){
                return cs->conf_cache;
        }
-       val = readq((void*)addr);
+       val = readq(addr);
        return val;
 }
 
@@ -176,7 +176,7 @@ kp_spi_write_reg(struct kp_spi_controller_state *cs, int idx, u64 val)
 {
        u64 __iomem *addr = cs->base;
        addr += idx;
-       writeq(val, (void*)addr);
+       writeq(val, addr);
        if (idx == KP_SPI_REG_CONFIG)
                cs->conf_cache = val;
 }