bus: sunxi-rsb: Fix error handling in sunxi_rsb_init()
authorYuan Can <yuancan@huawei.com>
Wed, 23 Nov 2022 09:42:00 +0000 (09:42 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2023 10:27:59 +0000 (11:27 +0100)
[ Upstream commit f71eaf2708be7831428eacae7db25d8ec6b8b4c5 ]

The sunxi_rsb_init() returns the platform_driver_register() directly
without checking its return value, if platform_driver_register() failed,
the sunxi_rsb_bus is not unregistered.
Fix by unregister sunxi_rsb_bus when platform_driver_register() failed.

Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20221123094200.12036-1-yuancan@huawei.com
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bus/sunxi-rsb.c

index 3aa91ae..226e87b 100644 (file)
@@ -857,7 +857,13 @@ static int __init sunxi_rsb_init(void)
                return ret;
        }
 
-       return platform_driver_register(&sunxi_rsb_driver);
+       ret = platform_driver_register(&sunxi_rsb_driver);
+       if (ret) {
+               bus_unregister(&sunxi_rsb_bus);
+               return ret;
+       }
+
+       return 0;
 }
 module_init(sunxi_rsb_init);