[libc++][PSTL] Remove _PSTL_HIDE_FROM_ABI_{PUSH,POP} macros

Reviewed By: ldionne, #libc

Spies: libcxx-commits, miyuki

Differential Revision: https://reviews.llvm.org/D149556

diff --git a/libcxx/include/__pstl/internal/algorithm_fwd.h b/libcxx/include/__pstl/internal/algorithm_fwd.h
index 8dccab1..4f6d731 100644 (file)
--- a/libcxx/include/__pstl/internal/algorithm_fwd.h
+++ b/libcxx/include/__pstl/internal/algorithm_fwd.h
@@ -16,8 +16,6 @@
 
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace __internal {
 
@@ -1768,6 +1766,4 @@ bool __pattern_lexicographical_compare(
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_ALGORITHM_FWD_H */

diff --git a/libcxx/include/__pstl/internal/algorithm_impl.h b/libcxx/include/__pstl/internal/algorithm_impl.h
index f380825..40b79f1 100644 (file)
--- a/libcxx/include/__pstl/internal/algorithm_impl.h
+++ b/libcxx/include/__pstl/internal/algorithm_impl.h
@@ -24,8 +24,6 @@
 #include "pstl_config.h"
 #include "unseq_backend_simd.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace __internal {
 
@@ -4339,6 +4337,4 @@ bool __pattern_lexicographical_compare(
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_ALGORITHM_IMPL_H */

diff --git a/libcxx/include/__pstl/internal/execution_defs.h b/libcxx/include/__pstl/internal/execution_defs.h
index 94d7da2..14fdc6b 100644 (file)
--- a/libcxx/include/__pstl/internal/execution_defs.h
+++ b/libcxx/include/__pstl/internal/execution_defs.h
@@ -14,8 +14,6 @@
 
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace execution {
 inline namespace v1 {
@@ -73,6 +71,4 @@ struct __parallel_tag;
 
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_EXECUTION_POLICY_DEFS_H */

diff --git a/libcxx/include/__pstl/internal/execution_impl.h b/libcxx/include/__pstl/internal/execution_impl.h
index 261a1c2..182075c 100644 (file)
--- a/libcxx/include/__pstl/internal/execution_impl.h
+++ b/libcxx/include/__pstl/internal/execution_impl.h
@@ -16,8 +16,6 @@
 #include "execution_defs.h"
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace __internal {
 
@@ -88,6 +86,4 @@ __select_backend(__pstl::execution::parallel_unsequenced_policy, _IteratorTypes&
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_EXECUTION_IMPL_H */

diff --git a/libcxx/include/__pstl/internal/glue_algorithm_defs.h b/libcxx/include/__pstl/internal/glue_algorithm_defs.h
index cd404f0..c251bd5 100644 (file)
--- a/libcxx/include/__pstl/internal/glue_algorithm_defs.h
+++ b/libcxx/include/__pstl/internal/glue_algorithm_defs.h
@@ -16,8 +16,6 @@
 #include "execution_defs.h"
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace std {
 
 // [alg.find.end]
@@ -695,6 +693,4 @@ __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, bool> lexicog
 
 } // namespace std
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_GLUE_ALGORITHM_DEFS_H */

diff --git a/libcxx/include/__pstl/internal/glue_algorithm_impl.h b/libcxx/include/__pstl/internal/glue_algorithm_impl.h
index ec11c8b..1f7d0cd 100644 (file)
--- a/libcxx/include/__pstl/internal/glue_algorithm_impl.h
+++ b/libcxx/include/__pstl/internal/glue_algorithm_impl.h
@@ -21,8 +21,6 @@
 
 #include "execution_impl.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace std {
 
 // [alg.find.end]
@@ -1191,6 +1189,4 @@ __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, bool> lexicog
 
 } // namespace std
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_GLUE_ALGORITHM_IMPL_H */

diff --git a/libcxx/include/__pstl/internal/glue_memory_defs.h b/libcxx/include/__pstl/internal/glue_memory_defs.h
index fe99a47..7357546 100644 (file)
--- a/libcxx/include/__pstl/internal/glue_memory_defs.h
+++ b/libcxx/include/__pstl/internal/glue_memory_defs.h
@@ -13,8 +13,6 @@
 #include "execution_defs.h"
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace std {
 
 // [uninitialized.copy]
@@ -79,6 +77,4 @@ uninitialized_value_construct_n(_ExecutionPolicy&& __exec, _ForwardIterator __fi
 
 } //  namespace std
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_GLUE_MEMORY_DEFS_H */

diff --git a/libcxx/include/__pstl/internal/glue_memory_impl.h b/libcxx/include/__pstl/internal/glue_memory_impl.h
index 7b45c1a..e65d694 100644 (file)
--- a/libcxx/include/__pstl/internal/glue_memory_impl.h
+++ b/libcxx/include/__pstl/internal/glue_memory_impl.h
@@ -18,8 +18,6 @@
 
 #include "execution_impl.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace std {
 
 // [uninitialized.copy]
@@ -378,6 +376,4 @@ uninitialized_value_construct_n(_ExecutionPolicy&& __exec, _ForwardIterator __fi
 
 } // namespace std
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_GLUE_MEMORY_IMPL_H */

diff --git a/libcxx/include/__pstl/internal/glue_numeric_defs.h b/libcxx/include/__pstl/internal/glue_numeric_defs.h
index 7cb7f32..40e0202 100644 (file)
--- a/libcxx/include/__pstl/internal/glue_numeric_defs.h
+++ b/libcxx/include/__pstl/internal/glue_numeric_defs.h
@@ -15,8 +15,6 @@
 #include "execution_defs.h"
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace std {
 // [reduce]
 
@@ -174,6 +172,4 @@ __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, _ForwardItera
 
 } // namespace std
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_GLUE_NUMERIC_DEFS_H */

diff --git a/libcxx/include/__pstl/internal/glue_numeric_impl.h b/libcxx/include/__pstl/internal/glue_numeric_impl.h
index aa518e1..4923191 100644 (file)
--- a/libcxx/include/__pstl/internal/glue_numeric_impl.h
+++ b/libcxx/include/__pstl/internal/glue_numeric_impl.h
@@ -18,8 +18,6 @@
 #include "numeric_fwd.h"
 #include "utils.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace std {
 
 // [reduce]
@@ -319,6 +317,4 @@ __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, _ForwardItera
 
 } // namespace std
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_GLUE_NUMERIC_IMPL_H_ */

diff --git a/libcxx/include/__pstl/internal/memory_impl.h b/libcxx/include/__pstl/internal/memory_impl.h
index 7c06ad7..1967d5d 100644 (file)
--- a/libcxx/include/__pstl/internal/memory_impl.h
+++ b/libcxx/include/__pstl/internal/memory_impl.h
@@ -15,8 +15,6 @@
 #include "pstl_config.h"
 #include "unseq_backend_simd.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace __internal {
 
@@ -105,6 +103,4 @@ _OutputIterator __brick_uninitialized_copy(
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_MEMORY_IMPL_H */

diff --git a/libcxx/include/__pstl/internal/numeric_fwd.h b/libcxx/include/__pstl/internal/numeric_fwd.h
index 8377faf..ccf7b63 100644 (file)
--- a/libcxx/include/__pstl/internal/numeric_fwd.h
+++ b/libcxx/include/__pstl/internal/numeric_fwd.h
@@ -15,8 +15,6 @@
 
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace __internal {
 
@@ -251,6 +249,4 @@ _OutputIterator __pattern_adjacent_difference(
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_NUMERIC_FWD_H */

diff --git a/libcxx/include/__pstl/internal/numeric_impl.h b/libcxx/include/__pstl/internal/numeric_impl.h
index 5ba2822..6b39176 100644 (file)
--- a/libcxx/include/__pstl/internal/numeric_impl.h
+++ b/libcxx/include/__pstl/internal/numeric_impl.h
@@ -20,8 +20,6 @@
 #include "unseq_backend_simd.h"
 #include "algorithm_fwd.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace __internal {
 
@@ -537,6 +535,4 @@ _RandomAccessIterator2 __pattern_adjacent_difference(
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_NUMERIC_IMPL_H */

diff --git a/libcxx/include/__pstl/internal/omp/util.h b/libcxx/include/__pstl/internal/omp/util.h
index c88d980..3c1a92e 100644 (file)
--- a/libcxx/include/__pstl/internal/omp/util.h
+++ b/libcxx/include/__pstl/internal/omp/util.h
@@ -31,8 +31,6 @@
 #    define _PSTL_PRAGMA(x) _Pragma(#    x)
 #endif
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl
 {
 namespace __omp_backend

diff --git a/libcxx/include/__pstl/internal/parallel_backend_serial.h b/libcxx/include/__pstl/internal/parallel_backend_serial.h
index 3692d9d..4225943 100644 (file)
--- a/libcxx/include/__pstl/internal/parallel_backend_serial.h
+++ b/libcxx/include/__pstl/internal/parallel_backend_serial.h
@@ -16,8 +16,6 @@
 
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl
 {
 namespace __serial_backend
@@ -130,6 +128,4 @@ __parallel_invoke(__pstl::__internal::__serial_backend_tag, _ExecutionPolicy&&,
 } // namespace __serial_backend
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_PARALLEL_BACKEND_SERIAL_H */

diff --git a/libcxx/include/__pstl/internal/parallel_backend_tbb.h b/libcxx/include/__pstl/internal/parallel_backend_tbb.h
index e336f69..aa08864 100644 (file)
--- a/libcxx/include/__pstl/internal/parallel_backend_tbb.h
+++ b/libcxx/include/__pstl/internal/parallel_backend_tbb.h
@@ -30,8 +30,6 @@
 #    error Intel(R) Threading Building Blocks 2018 is required; older versions are not supported.
 #endif
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl
 {
 namespace __tbb_backend
@@ -1291,6 +1289,4 @@ __parallel_invoke(__pstl::__internal::__tbb_backend_tag, _ExecutionPolicy&&, _F1
 } // namespace __tbb_backend
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_PARALLEL_BACKEND_TBB_H */

diff --git a/libcxx/include/__pstl/internal/parallel_backend_utils.h b/libcxx/include/__pstl/internal/parallel_backend_utils.h
index e176d7e..9d9e0c5 100644 (file)
--- a/libcxx/include/__pstl/internal/parallel_backend_utils.h
+++ b/libcxx/include/__pstl/internal/parallel_backend_utils.h
@@ -16,8 +16,6 @@
 
 #include "pstl_config.h"
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl
 {
 
@@ -258,6 +256,4 @@ __set_symmetric_difference_construct(_ForwardIterator1 __first1, _ForwardIterato
 } // namespace __utils
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_PARALLEL_BACKEND_UTILS_H */

diff --git a/libcxx/include/__pstl/internal/parallel_impl.h b/libcxx/include/__pstl/internal/parallel_impl.h
index aa268de..ff56ae6 100644 (file)
--- a/libcxx/include/__pstl/internal/parallel_impl.h
+++ b/libcxx/include/__pstl/internal/parallel_impl.h
@@ -17,8 +17,6 @@
 // This header defines the minimum set of parallel routines required to support Parallel STL,
 // implemented on top of Intel(R) Threading Building Blocks (Intel(R) TBB) library
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl
 {
 namespace __internal
@@ -84,6 +82,4 @@ bool __parallel_or(_BackendTag __tag, _ExecutionPolicy&& __exec, _Index __first,
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_PARALLEL_IMPL_H */

diff --git a/libcxx/include/__pstl/internal/pstl_config.h b/libcxx/include/__pstl/internal/pstl_config.h
index fbc3aca..9361863 100644 (file)
--- a/libcxx/include/__pstl/internal/pstl_config.h
+++ b/libcxx/include/__pstl/internal/pstl_config.h
@@ -49,15 +49,6 @@
 #define _PSTL_STRING(x) _PSTL_STRING_AUX(x)
 #define _PSTL_STRING_CONCAT(x, y) x #y
 
-#ifdef _PSTL_HIDE_FROM_ABI_PER_TU
-#    define _PSTL_HIDE_FROM_ABI_PUSH                                                                                   \
-        _Pragma("clang attribute push(__attribute__((internal_linkage)), apply_to=any(function,record))")
-#    define _PSTL_HIDE_FROM_ABI_POP _Pragma("clang attribute pop")
-#else
-#    define _PSTL_HIDE_FROM_ABI_PUSH /* nothing */
-#    define _PSTL_HIDE_FROM_ABI_POP  /* nothing */
-#endif
-
 // note that when ICC or Clang is in use, _PSTL_GCC_VERSION might not fully match
 // the actual GCC version on the system.
 #define _PSTL_GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__)

diff --git a/libcxx/include/__pstl/internal/unseq_backend_simd.h b/libcxx/include/__pstl/internal/unseq_backend_simd.h
index 746157f..8009f8d 100644 (file)
--- a/libcxx/include/__pstl/internal/unseq_backend_simd.h
+++ b/libcxx/include/__pstl/internal/unseq_backend_simd.h
@@ -19,8 +19,6 @@
 // This header defines the minimum set of vector routines required
 // to support parallel STL.
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl
 {
 namespace __unseq_backend
@@ -858,6 +856,4 @@ __simd_remove_if(_RandomAccessIterator __first, _DifferenceType __n, _UnaryPredi
 } // namespace __unseq_backend
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_UNSEQ_BACKEND_SIMD_H */

diff --git a/libcxx/include/__pstl/internal/utils.h b/libcxx/include/__pstl/internal/utils.h
index 712a314..d0236f1 100644 (file)
--- a/libcxx/include/__pstl/internal/utils.h
+++ b/libcxx/include/__pstl/internal/utils.h
@@ -15,8 +15,6 @@
 #include <new>
 #include <utility>
 
-_PSTL_HIDE_FROM_ABI_PUSH
-
 namespace __pstl {
 namespace __internal {
 
@@ -137,6 +135,4 @@ _ForwardIterator __cmp_iterators_by_values(_ForwardIterator __a, _ForwardIterato
 } // namespace __internal
 } // namespace __pstl
 
-_PSTL_HIDE_FROM_ABI_POP
-
 #endif /* _PSTL_UTILS_H */