validate: launcher: Split test log file handling in Reporter

Patch 3/5 to move logfile handling out of Reporter and into Test.

diff --git a/validate/launcher/baseclasses.py b/validate/launcher/baseclasses.py
index 308a2d376ed7a83f8d3116b4ae269d93f640d936..1b539639db3d274ff56f79ce8f26b80f82193c8c 100644 (file)
--- a/validate/launcher/baseclasses.py
+++ b/validate/launcher/baseclasses.py
@@ -748,10 +748,11 @@ class TestsManager(Loggable):
         i = cur_test_num
         for test in self.tests:
             sys.stdout.write("[%d / %d] " % (i + 1, total_num_tests))
-            self.reporter.before_test(test)
+            self.reporter.open_logfile(test)
             res = test.run()
             i += 1
             self.reporter.after_test(test)
+            self.reporter.close_logfile()
             if res != Result.PASSED and (self.options.forever or
                                          self.options.fatal_error):
                 return test.result

diff --git a/validate/launcher/reporters.py b/validate/launcher/reporters.py
index ba4e4a29a5e8bcf77032fc11703f2f632055c66d..842b8521b069d37950deec974997ff33f4c2c85a 100644 (file)
--- a/validate/launcher/reporters.py
+++ b/validate/launcher/reporters.py
@@ -69,7 +69,7 @@ class Reporter(Loggable):
         """Initialize a timer before starting tests."""
         self._start_time = time.time()
 
-    def before_test(self, test):
+    def open_logfile(self, test):
         path = os.path.join(self.options.logsdir,
                             test.classname.replace(".", os.sep))
         mkdir(os.path.dirname(path))
@@ -103,6 +103,8 @@ class Reporter(Loggable):
             self.results.append(test)
 
         self.add_results(test)
+
+    def close_logfile(self):
         if not self.options.redirect_logs:
             self.out.close()