elm: call eina_value_flush to deallocate memory
authorAmitesh Singh <amitesh.sh@samsung.com>
Mon, 30 Oct 2017 11:27:53 +0000 (20:27 +0900)
committerAmitesh Singh <amitesh.sh@samsung.com>
Mon, 30 Oct 2017 11:29:42 +0000 (20:29 +0900)
I am not sure if Eina_Value allocates dynamic memory
for basic types but its better practice to call eina_value_flush()
at the end.

src/lib/elementary/efl_ui_multibuttonentry.c
src/lib/elementary/efl_ui_progressbar.c
src/lib/elementary/efl_ui_slider.c

index 0414bc7..b8c23e3 100644 (file)
@@ -278,6 +278,8 @@ _shrink_mode_set(Evas_Object *obj,
              efl_event_callback_legacy_call
                (obj, EFL_UI_MULTIBUTTONENTRY_EVENT_EXPAND_STATE_CHANGED, (void *)1);
           }
+
+        eina_value_flush(&val);
      }
    else
      {
index fdb8e2e..461869c 100644 (file)
@@ -118,6 +118,8 @@ _units_set(Evas_Object *obj)
         eina_strbuf_reset(sd->format_strbuf);
         sd->format_cb(sd->format_cb_data, sd->format_strbuf, val);
         elm_layout_text_set(obj, "elm.text.status", eina_strbuf_string_get(sd->format_strbuf));
+
+        eina_value_flush(&val);
      }
    else
      elm_layout_text_set(obj, "elm.text.status", NULL);
index a1c8fa9..38d0ff8 100644 (file)
@@ -241,6 +241,8 @@ _units_set(Evas_Object *obj)
              elm_layout_signal_emit(obj, "elm,state,units,visible", "elm");
              sd->units_show = EINA_TRUE;
           }
+
+        eina_value_flush(&val);
      }
    else
      {