[wasm] Fix runtime test failing due to the app running in debug mode (#70050)
authorAnkit Jain <radical@gmail.com>
Wed, 1 Jun 2022 19:05:13 +0000 (15:05 -0400)
committerGitHub <noreply@github.com>
Wed, 1 Jun 2022 19:05:13 +0000 (15:05 -0400)
* [wasm] Fix runtime test failing due to the app running in debug mode

Fixes https://github.com/dotnet/runtime/issues/69517

- Recent [wasm-app-host commit](6b3ea401ca20c26dbb5497b0fbbf77b3afc73374) changed `WasmApp.targets` so
  `WasmDebugLevel` would be set to enable debugging if
  `Configuration==Debug`.
    - this broke some runtime tests which depend on tail call
    optimizations, which get disabled when debugging is enabled in the
    runtime.

- And the wasm apps for the runtime tests are being built with no
  configuration set, which defaults to `Debug`. Instead, propogate the
  config for the build to the wasm proxy (`WasmTestRunner`) projects too.

Fixes https://github.com/dotnet/runtime/issues/69517 .

* Revert "[wasm] Disable runtime test failing due to stack overflow (#69863)"

This reverts commit 61441fae579149181dc973ae4e58eccd4beef728.

src/tests/Directory.Build.props
src/tests/issues.targets

index 606bf57..c0dcca3 100644 (file)
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(TargetOS)' == 'Browser'">
-    <CLRTestMSBuildArgs>/p:MSBuildEnableWorkloadResolver=false</CLRTestMSBuildArgs>
+    <CLRTestMSBuildArgs>/p:MSBuildEnableWorkloadResolver=false /p:Configuration=$(Configuration)</CLRTestMSBuildArgs>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(IsTestsCommonProject)' != 'true'">
index f2ad66e..7fc537a 100644 (file)
 
 
     <ItemGroup Condition=" '$(TargetArchitecture)' == 'wasm' " >
-        <ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/tailcall/**">
-            <Issue>https://github.com/dotnet/runtime/issues/69517</Issue>
-        </ExcludeList>
-        <ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/IL/Tailcall/ExplicitTailCallNoSO/*">
-            <Issue>https://github.com/dotnet/runtime/issues/69517</Issue>
-        </ExcludeList>
-
         <ExcludeList Include="$(XunitTestBinBase)/JIT/Intrinsics/TypeIntrinsics_r/**">
             <Issue>https://github.com/dotnet/runtime/issues/54867</Issue>
         </ExcludeList>