media: aspeed: use DEFINE_SHOW_ATTRIBUTE to simplify code
authorLiu Shixin <liushixin2@huawei.com>
Thu, 22 Sep 2022 14:30:38 +0000 (22:30 +0800)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 24 Oct 2022 17:03:52 +0000 (19:03 +0200)
Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
No functional change.

Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/aspeed/aspeed-video.c

index 20f795c..26f067c 100644 (file)
@@ -1753,19 +1753,7 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data)
 
        return 0;
 }
-
-static int aspeed_video_proc_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, aspeed_video_debugfs_show, inode->i_private);
-}
-
-static const struct file_operations aspeed_video_debugfs_ops = {
-       .owner   = THIS_MODULE,
-       .open    = aspeed_video_proc_open,
-       .read    = seq_read,
-       .llseek  = seq_lseek,
-       .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(aspeed_video_debugfs);
 
 static struct dentry *debugfs_entry;
 
@@ -1779,7 +1767,7 @@ static int aspeed_video_debugfs_create(struct aspeed_video *video)
 {
        debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL,
                                            video,
-                                           &aspeed_video_debugfs_ops);
+                                           &aspeed_video_debugfs_fops);
        if (!debugfs_entry)
                aspeed_video_debugfs_remove(video);