sfc: ef10: fix TX queue lookup in TX event handling
authorEdward Cree <ecree.xilinx@gmail.com>
Tue, 20 Apr 2021 12:29:35 +0000 (13:29 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Apr 2021 00:03:53 +0000 (17:03 -0700)
We're starting from a TXQ label, not a TXQ type, so
 efx_channel_get_tx_queue() is inappropriate.  This worked by chance,
 because labels and types currently match on EF10, but we shouldn't
 rely on that.

Fixes: 12804793b17c ("sfc: decouple TXQ type from label")
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ef10.c

index da6886d..4fa72b5 100644 (file)
@@ -2928,8 +2928,7 @@ efx_ef10_handle_tx_event(struct efx_channel *channel, efx_qword_t *event)
 
        /* Get the transmit queue */
        tx_ev_q_label = EFX_QWORD_FIELD(*event, ESF_DZ_TX_QLABEL);
-       tx_queue = efx_channel_get_tx_queue(channel,
-                                           tx_ev_q_label % EFX_MAX_TXQ_PER_CHANNEL);
+       tx_queue = channel->tx_queue + (tx_ev_q_label % EFX_MAX_TXQ_PER_CHANNEL);
 
        if (!tx_queue->timestamping) {
                /* Transmit completion */