Fix MSVC "not all control paths return a value" warning. NFCI.
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Fri, 21 Feb 2020 18:23:29 +0000 (18:23 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Fri, 21 Feb 2020 18:23:55 +0000 (18:23 +0000)
clang/lib/ASTMatchers/GtestMatchers.cpp

index 317bddd..c99fdf6 100644 (file)
@@ -38,6 +38,7 @@ static DeclarationMatcher getComparisonDecl(GtestCmp Cmp) {
     case GtestCmp::Lt:
       return functionDecl(hasName("::testing::internal::CmpHelperLT"));
   }
+  llvm_unreachable("Unhandled GtestCmp enum");
 }
 
 static llvm::StringRef getAssertMacro(GtestCmp Cmp) {
@@ -55,6 +56,7 @@ static llvm::StringRef getAssertMacro(GtestCmp Cmp) {
     case GtestCmp::Lt:
       return "ASSERT_LT";
   }
+  llvm_unreachable("Unhandled GtestCmp enum");
 }
 
 static llvm::StringRef getExpectMacro(GtestCmp Cmp) {
@@ -72,6 +74,7 @@ static llvm::StringRef getExpectMacro(GtestCmp Cmp) {
     case GtestCmp::Lt:
       return "EXPECT_LT";
   }
+  llvm_unreachable("Unhandled GtestCmp enum");
 }
 
 // In general, AST matchers cannot match calls to macros. However, we can