After #3097, the java side pass command line argument to JNI for freerdp settings. However there's several issues need to be fixed:
1. The argument /sound should be appended if freerdp is required to play sound at local device
2. The option value for "audio-mode" is not correct.
It should match the definition in client/common/cmdline.c
/* Audio Mode */
define AUDIO_MODE_REDIRECT 0 /* Bring to this computer */
define AUDIO_MODE_PLAY_ON_SERVER 1 /* Leave at remote computer */
define AUDIO_MODE_NONE 2 /* Do not play */
3. Uncomment support for WAVE_FORMAT_PCM in audin. I tested on my android phone and Nokia N1 tablet. It works on both device
switch (format->wFormatTag)
{
- /* TODO: Deactivated, untested */
-#if 0
case WAVE_FORMAT_PCM: /* PCM */
if (format->cbSize == 0 &&
(format->nSamplesPerSec <= 48000) &&
return TRUE;
}
break;
-#endif
/* TODO: Deactivated format, does not work, find out why */
// case WAVE_FORMAT_ADPCM: /* IMA ADPCM */
case WAVE_FORMAT_DVI_ADPCM:
}
}
- /* 0 ... disable
- 1 ... local
- 2 ... remote */
+ /* 0 ... local
+ 1 ... remote
+ 2 ... disable */
args.add("/audio-mode:" + String.valueOf(advanced.getRedirectSound()));
+ if (advanced.getRedirectSound() == 0) {
+ args.add("/sound");
+ }
if (advanced.getRedirectMicrophone()) {
args.add("/microphone");
<item>Auf Client abspielen</item>
</string-array>
<string-array name="redirect_sound_values_array">
- <item>0</item>
- <item>1</item>
<item>2</item>
+ <item>1</item>
+ <item>0</item>
</string-array>
<string name="settings_redirect_microphone">Mikrophon umleiten</string>
<string name="settings_security">Sicherheit</string>
<item>Play on Device</item>\r
</string-array>\r
<string-array name="redirect_sound_values_array">\r
- <item>0</item>\r
- <item>1</item>\r
<item>2</item>\r
+ <item>1</item>\r
+ <item>0</item>\r
</string-array>\r
<string name="settings_redirect_microphone">Redirect Microphone</string>\r
<string name="settings_security">Seguridad</string>\r
<item>Play on Device</item>
</string-array>
<string-array name="redirect_sound_values_array">
- <item>0</item>
- <item>1</item>
<item>2</item>
+ <item>1</item>
+ <item>0</item>
</string-array>
<string name="settings_redirect_microphone">Redirect Microphone</string>
<string name="settings_security">"Securité"</string>
<item>Play on Device</item>
</string-array>
<string-array name="redirect_sound_values_array">
- <item>0</item>
- <item>1</item>
<item>2</item>
+ <item>1</item>
+ <item>0</item>
</string-array>
<string name="settings_redirect_microphone">Redirect Microphone</string>
<string name="settings_security">Beveiliging</string>
<item>在此设备上播放</item>
</string-array>
<string-array name="redirect_sound_values_array">
- <item>0</item>
- <item>1</item>
<item>2</item>
+ <item>1</item>
+ <item>0</item>
</string-array>
<string name="settings_redirect_microphone">麦克风重定向</string>
<string name="settings_security">连接协议</string>
<item>Play on Device</item>
</string-array>
<string-array name="redirect_sound_values_array">
- <item>0</item>
- <item>1</item>
<item>2</item>
+ <item>1</item>
+ <item>0</item>
</string-array>
<string name="settings_redirect_microphone">Redirect Microphone</string>
<string name="settings_security">Security</string>