Fix enum values in pipeline robustness tests
authorRicardo Garcia <rgarcia@igalia.com>
Wed, 28 Sep 2022 11:32:48 +0000 (13:32 +0200)
committerMatthew Netsch <quic_mnetsch@quicinc.com>
Mon, 10 Oct 2022 16:04:03 +0000 (16:04 +0000)
Pipeline robustness tests fill out VkPipelineRobustnessCreateInfoEXT
structures using robustness2 values when robustness2 is not activated,
and vice versa.

Affected tests:
dEQP-VK.robustness.pipeline_robustness.*

Components: Vulkan
VK-GL-CTS issue: 4004

Change-Id: Ic3abe5fda40cc999a7ee288aa5df35ee407743f2

external/vulkancts/modules/vulkan/robustness/vktRobustnessExtsTests.cpp

index 9e9daeb..1b51ab7 100644 (file)
@@ -546,50 +546,30 @@ static VkPipelineRobustnessCreateInfoEXT getPipelineRobustnessInfo(bool robustne
                case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
                case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
                case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
-                       if (robustness2)
-                       {
-                               robustnessCreateInfo.storageBuffers = VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_EXT;
-                       }
-                       else
-                       {
-                               robustnessCreateInfo.storageBuffers = VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_2_EXT;
-                       }
+                       robustnessCreateInfo.storageBuffers     = (robustness2
+                                                                                               ? VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_2_EXT
+                                                                                               : VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_EXT);
                        break;
 
                case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
                case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
-                       if (robustness2)
-                       {
-                               robustnessCreateInfo.images = VK_PIPELINE_ROBUSTNESS_IMAGE_BEHAVIOR_ROBUST_IMAGE_ACCESS_EXT;
-                       }
-                       else
-                       {
-                               robustnessCreateInfo.images = VK_PIPELINE_ROBUSTNESS_IMAGE_BEHAVIOR_ROBUST_IMAGE_ACCESS_2_EXT;
-                       }
+                       robustnessCreateInfo.images     = (robustness2
+                                                                               ? VK_PIPELINE_ROBUSTNESS_IMAGE_BEHAVIOR_ROBUST_IMAGE_ACCESS_2_EXT
+                                                                               : VK_PIPELINE_ROBUSTNESS_IMAGE_BEHAVIOR_ROBUST_IMAGE_ACCESS_EXT);
                        break;
 
                case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
                case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
                case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
-                       if (robustness2)
-                       {
-                               robustnessCreateInfo.uniformBuffers = VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_EXT;
-                       }
-                       else
-                       {
-                               robustnessCreateInfo.uniformBuffers = VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_2_EXT;
-                       }
+                       robustnessCreateInfo.uniformBuffers     = (robustness2
+                                                                                               ? VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_2_EXT
+                                                                                               : VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_EXT);
                        break;
 
                case VERTEX_ATTRIBUTE_FETCH:
-                       if (robustness2)
-                       {
-                               robustnessCreateInfo.vertexInputs = VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_EXT;
-                       }
-                       else
-                       {
-                               robustnessCreateInfo.vertexInputs = VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_2_EXT;
-                       }
+                       robustnessCreateInfo.vertexInputs       = (robustness2
+                                                                                               ? VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_2_EXT
+                                                                                               : VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_ROBUST_BUFFER_ACCESS_EXT);
                        break;
 
                default: