tst_dialogs: QTRY_ on the expression (spyVisibilityChanged.count) not the variable.

We only assign to the variable once, so the value may not change in time.

Change-Id: I54ac7faad60d3984bfde4606aaf7e30a2340ba3e
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>

diff --git a/tests/auto/quick/dialogs/tst_dialogs.cpp b/tests/auto/quick/dialogs/tst_dialogs.cpp
index 1ab10cc..df3728e 100644 (file)
--- a/tests/auto/quick/dialogs/tst_dialogs.cpp
+++ b/tests/auto/quick/dialogs/tst_dialogs.cpp
@@ -124,8 +124,8 @@ void tst_dialogs::fileDialogNonModal()
     dlg->setProperty("modality", QVariant((int)Qt::NonModal));
     QSignalSpy spyVisibilityChanged(dlg, SIGNAL(visibilityChanged()));
     QTest::mouseClick(window, Qt::LeftButton, 0, QPoint(1000, 100));  // show
+    QTRY_VERIFY(spyVisibilityChanged.count() > 0);
     int visibilityChangedCount = spyVisibilityChanged.count();
-    QTRY_VERIFY(visibilityChangedCount > 0);
     QCOMPARE(dlg->property("visible").toBool(), true);
     QTest::mouseClick(window, Qt::LeftButton, 0, QPoint(1000, 100));  // hide
     QTRY_VERIFY(spyVisibilityChanged.count() > visibilityChangedCount);