drm/fb-helper: Set plane rotation directly
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 16 Oct 2015 16:23:13 +0000 (18:23 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 19 Oct 2015 09:00:48 +0000 (11:00 +0200)
The point behind standardizing properties into core drm state
structures is also that internal code looks prettiers. Take advantage
of that and set rotation directly in the fbdev atomic code.

Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1445012594-25988-1-git-send-email-daniel.vetter@ffwll.ch
Acked-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_fb_helper.c

index abe9793..80e0631 100644 (file)
@@ -360,11 +360,7 @@ retry:
                        goto fail;
                }
 
-               ret = drm_atomic_plane_set_property(plane, plane_state,
-                               dev->mode_config.rotation_property,
-                               BIT(DRM_ROTATE_0));
-               if (ret != 0)
-                       goto fail;
+               plane_state->rotation = BIT(DRM_ROTATE_0);
 
                /* disable non-primary: */
                if (plane->type == DRM_PLANE_TYPE_PRIMARY)