rtlwifi: Fix file release memory leak
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 4 Sep 2019 14:16:11 +0000 (14:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:51:11 +0000 (14:51 +0100)
[ Upstream commit 4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e ]

When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.

This is detected by Coccinelle semantic patch.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtlwifi/debug.c

index d70385b..4989940 100644 (file)
@@ -109,7 +109,7 @@ static const struct file_operations file_ops_common = {
        .open = dl_debug_open_common,
        .read = seq_read,
        .llseek = seq_lseek,
-       .release = seq_release,
+       .release = single_release,
 };
 
 static int rtl_debug_get_mac_page(struct seq_file *m, void *v)