Correct to check return of fread

Change-Id: I2be0a615a5a5052f56c1c4958f9575033c952b38
Signed-off-by: Wonnam Jang <wn.jang@samsung.com>

diff --git a/client/vc.c b/client/vc.c
index 9cfc04b..b3c9b24 100644 (file)
--- a/client/vc.c
+++ b/client/vc.c
@@ -110,7 +110,7 @@ static int __check_privilege(const char* uid, const char * privilege)
 
        fp = fopen(label_path, "r");
        if (fp != NULL) {
-               if (strlen(smack_label) != fread(smack_label, 1, sizeof(smack_label), fp))
+               if (0 >= fread(smack_label, 1, sizeof(smack_label), fp))
                        SLOG(LOG_ERROR, TAG_VCC, "[ERROR] fail to fread");
 
                fclose(fp);

diff --git a/common/vc_command.c b/common/vc_command.c
index 77e363b..282f9a4 100644 (file)
--- a/common/vc_command.c
+++ b/common/vc_command.c
@@ -102,7 +102,7 @@ static int __check_privilege(const char* uid, const char * privilege)
 
        fp = fopen(label_path, "r");
        if (fp != NULL) {
-               if (sizeof(smack_label) != fread(smack_label, 1, sizeof(smack_label), fp))
+               if (0 >= fread(smack_label, 1, sizeof(smack_label), fp))
                        SLOG(LOG_ERROR, TAG_VCCMD, "[ERROR] fail to fread");
 
                fclose(fp);