[NUI] Fix SVACE issues

1) DF240922-00003
https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=43585
false alarm
At line 755, a null check has been already performed ; the item "e.Proposed" which was pointed out as an problem cannot become null.
As such, this issue does not require correction as it is a false alarm.

2) DF240907-00723
https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=176282
fixed

3) DF240907-00695
https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=176248
fixed

4) DF240906-00277
https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=174470
fixed

5) DF240905-01180
https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=43601

At line 1014, a null check has been already performed; if it is null, an exception will be thrown.
Therefore, at line 1018, the item which was pointed out as an problem cannot become null.
As such, this issue does not require correction as it is a false alarm.

6) DF240821-00053
https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=163282
fixed

7) DF240716-01912
https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=163084
already fixed in the previous patch

diff --git a/src/Tizen.NUI/src/internal/Common/EnumHelper.cs b/src/Tizen.NUI/src/internal/Common/EnumHelper.cs
index 7de41f9085ccae33e03d15879f399a9007ff8cfc..44554f8b1f82f361a2e6c9de5862dd43349e53b9 100755 (executable)
--- a/src/Tizen.NUI/src/internal/Common/EnumHelper.cs
+++ b/src/Tizen.NUI/src/internal/Common/EnumHelper.cs
@@ -74,7 +74,7 @@ namespace Tizen.NUI
                 }
             }
 
-            var value = type.GetFields(BindingFlags.Public | BindingFlags.Static).FirstOrDefault().GetValue(null);
+            var value = type.GetFields(BindingFlags.Public | BindingFlags.Static).FirstOrDefault()?.GetValue(null);
             return value != null ? (T)value : default(T);
             //throw new ArgumentException($"{description} can't be found.", "Description");
         }

diff --git a/src/Tizen.NUI/src/internal/EXaml/Operation/AddToDictionary.cs b/src/Tizen.NUI/src/internal/EXaml/Operation/AddToDictionary.cs
index ddd7eee7852c86ad071673fe4e58b9a0b2ecd199..e5f50532089e079f0c8a8185d9b9f4d9679e49d6 100755 (executable)
--- a/src/Tizen.NUI/src/internal/EXaml/Operation/AddToDictionary.cs
+++ b/src/Tizen.NUI/src/internal/EXaml/Operation/AddToDictionary.cs
@@ -44,7 +44,7 @@ namespace Tizen.NUI.EXaml
             var type = dict.GetType();
             var method = type.GetMethods().FirstOrDefault(m => m.Name == "Add");
 
-            method.Invoke(dict, new object[] { key, value });
+            method?.Invoke(dict, new object[] { key, value });
         }
 
         private int parentIndex;

diff --git a/src/Tizen.NUI/src/public/BaseComponents/ViewInternal.cs b/src/Tizen.NUI/src/public/BaseComponents/ViewInternal.cs
index cf134a84b2b52ecf250170a98f6619c53f3fbf9c..0c6e68b51da83d57fe880dab50f53356921048dc 100755 (executable)
--- a/src/Tizen.NUI/src/public/BaseComponents/ViewInternal.cs
+++ b/src/Tizen.NUI/src/public/BaseComponents/ViewInternal.cs
@@ -496,7 +496,7 @@ namespace Tizen.NUI.BaseComponents
         internal Position GetCurrentParentOrigin()
         {
 
-            if(internalCurrentParentOrigin == null)
+            if (internalCurrentParentOrigin == null)
             {
                 internalCurrentParentOrigin = new Position(0, 0, 0);
             }
@@ -520,7 +520,7 @@ namespace Tizen.NUI.BaseComponents
         internal Position GetCurrentAnchorPoint()
         {
 
-            if(internalCurrentAnchorPoint == null)
+            if (internalCurrentAnchorPoint == null)
             {
                 internalCurrentAnchorPoint = new Position(0, 0, 0);
             }
@@ -565,7 +565,7 @@ namespace Tizen.NUI.BaseComponents
         internal Vector3 GetTargetSize()
         {
 
-            if(internalTargetSize == null)
+            if (internalTargetSize == null)
             {
                 internalTargetSize = new Vector3(0, 0, 0);
             }
@@ -582,7 +582,7 @@ namespace Tizen.NUI.BaseComponents
         internal Size2D GetCurrentSize()
         {
 
-            if(internalCurrentSize == null)
+            if (internalCurrentSize == null)
             {
                 internalCurrentSize = new Size2D(0, 0);
             }
@@ -647,7 +647,7 @@ namespace Tizen.NUI.BaseComponents
         internal Position GetCurrentPosition()
         {
 
-            if(internalCurrentPosition == null)
+            if (internalCurrentPosition == null)
             {
                 internalCurrentPosition = new Position(0, 0, 0);
             }
@@ -663,7 +663,7 @@ namespace Tizen.NUI.BaseComponents
         internal Vector3 GetCurrentWorldPosition()
         {
 
-            if(internalCurrentWorldPosition == null)
+            if (internalCurrentWorldPosition == null)
             {
                 internalCurrentWorldPosition = new Vector3(0, 0, 0);
             }
@@ -680,7 +680,7 @@ namespace Tizen.NUI.BaseComponents
         internal Vector2 GetCurrentScreenPosition()
         {
 
-            if(internalCurrentScreenPosition == null)
+            if (internalCurrentScreenPosition == null)
             {
                 internalCurrentScreenPosition = new Vector2(0, 0);
             }
@@ -792,7 +792,7 @@ namespace Tizen.NUI.BaseComponents
         internal Vector3 GetCurrentScale()
         {
 
-            if(internalCurrentScale == null)
+            if (internalCurrentScale == null)
             {
                 internalCurrentScale = new Vector3(0, 0, 0);
             }
@@ -809,7 +809,7 @@ namespace Tizen.NUI.BaseComponents
         internal Vector3 GetCurrentWorldScale()
         {
 
-            if(internalCurrentWorldScale == null)
+            if (internalCurrentWorldScale == null)
             {
                 internalCurrentWorldScale = new Vector3(0, 0, 0);
             }
@@ -886,7 +886,7 @@ namespace Tizen.NUI.BaseComponents
         internal Vector4 GetCurrentColor()
         {
 
-            if(internalCurrentColor == null)
+            if (internalCurrentColor == null)
             {
                 internalCurrentColor = new Vector4(0, 0, 0, 0);
             }
@@ -910,7 +910,7 @@ namespace Tizen.NUI.BaseComponents
         internal Vector4 GetCurrentWorldColor()
         {
 
-            if(internalCurrentWorldColor == null)
+            if (internalCurrentWorldColor == null)
             {
                 internalCurrentWorldColor = new Vector4(0, 0, 0, 0);
             }
@@ -1002,12 +1002,12 @@ namespace Tizen.NUI.BaseComponents
         internal Vector3 GetSizeModeFactor()
         {
 
-                if (internalSizeModeFactor == null)
-                {
-                    internalSizeModeFactor = new Vector3(OnSizeModeFactorChanged, 0, 0, 0);
-                }
-                Object.InternalRetrievingPropertyVector3(SwigCPtr, View.Property.SizeModeFactor, internalSizeModeFactor.SwigCPtr);
-                return internalSizeModeFactor;
+            if (internalSizeModeFactor == null)
+            {
+                internalSizeModeFactor = new Vector3(OnSizeModeFactorChanged, 0, 0, 0);
+            }
+            Object.InternalRetrievingPropertyVector3(SwigCPtr, View.Property.SizeModeFactor, internalSizeModeFactor.SwigCPtr);
+            return internalSizeModeFactor;
         }
 
         internal void SetMinimumSize(Vector2 size)
@@ -1437,7 +1437,10 @@ namespace Tizen.NUI.BaseComponents
 
                 foreach (View view in Children)
                 {
-                    view.InternalParent = null;
+                    if (view != null)
+                    {
+                        view.InternalParent = null;
+                    }
                 }
 
                 if (themeData != null)
@@ -1746,7 +1749,7 @@ namespace Tizen.NUI.BaseComponents
             if (readingSkippedCallback != null)
             {
                 NUILog.Debug($"[Dispose] readingSkippedCallback");
-                
+
                 ReadingSkippedSignal?.Disconnect(readingSkippedCallback);
                 ReadingSkippedSignal?.Dispose();
                 ReadingSkippedSignal = null;

diff --git a/src/Tizen.NUI/src/public/CustomView/CustomViewRegistry.cs b/src/Tizen.NUI/src/public/CustomView/CustomViewRegistry.cs
index 1a40e45cf511a797425d28b134e96a5ae5c0cac9..02f51201c8506ea7e6cf4b11661f457404795fc7 100755 (executable)
--- a/src/Tizen.NUI/src/public/CustomView/CustomViewRegistry.cs
+++ b/src/Tizen.NUI/src/public/CustomView/CustomViewRegistry.cs
@@ -406,7 +406,7 @@ namespace Tizen.NUI
             View view = Registry.GetManagedBaseHandleFromRefObject(refObjectPtr) as View;
             if (view != null)
             {
-                System.Reflection.PropertyInfo propertyInfo = view.GetType().GetProperty(propertyName);
+                System.Reflection.PropertyInfo propertyInfo = view.GetType().GetProperty(propertyName) ?? throw new global::System.InvalidOperationException("propertyInfo is null! can not set any value!");
                 // We know the property name, we know it's type, we just need to convert from a DALi property value to native C# type
                 System.Type type = propertyInfo?.PropertyType;
                 bool ok = false;