rtc: rv3028: Use IRQ flags obtained from device tree if available
authorWadim Egorov <w.egorov@phytec.de>
Thu, 8 Dec 2022 13:36:05 +0000 (14:36 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 15 Dec 2022 22:34:31 +0000 (23:34 +0100)
Make the interrupt pin of the RV3028 usable with GPIO controllers
without level type IRQs support, such as the TI Davinci GPIO controller.

Therefore, allow the IRQ type to be passed from the device tree if
available.

Based on commit d4785b46345c ("rtc: pcf2127: use IRQ flags obtained from device tree if available")

Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
Link: https://lore.kernel.org/r/20221208133605.4193907-1-w.egorov@phytec.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-rv3028.c

index dd170e3..b0099e2 100644 (file)
@@ -902,9 +902,20 @@ static int rv3028_probe(struct i2c_client *client)
                return PTR_ERR(rv3028->rtc);
 
        if (client->irq > 0) {
+               unsigned long flags;
+
+               /*
+                * If flags = 0, devm_request_threaded_irq() will use IRQ flags
+                * obtained from device tree.
+                */
+               if (dev_fwnode(&client->dev))
+                       flags = 0;
+               else
+                       flags = IRQF_TRIGGER_LOW;
+
                ret = devm_request_threaded_irq(&client->dev, client->irq,
                                                NULL, rv3028_handle_irq,
-                                               IRQF_TRIGGER_LOW | IRQF_ONESHOT,
+                                               flags | IRQF_ONESHOT,
                                                "rv3028", rv3028);
                if (ret) {
                        dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n");