kexec: remove redundant assignments
authorMichal Orzel <michalorzel.eng@gmail.com>
Fri, 29 Apr 2022 21:38:03 +0000 (14:38 -0700)
committerakpm <akpm@linux-foundation.org>
Fri, 29 Apr 2022 21:38:03 +0000 (14:38 -0700)
Get rid of redundant assignments which end up in values not being read
either because they are overwritten or the function ends.

Reported by clang-tidy [deadcode.DeadStores]

Link: https://lkml.kernel.org/r/20220326180948.192154-1-michalorzel.eng@gmail.com
Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Acked-by: Baoquan He <bhe@redhat.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Michal Orzel <michalorzel.eng@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/kexec_core.c

index 68480f731192ebe325f607953dbdcc70d2dfbe18..d08904a27362ceadf635e434da132556ad933eaf 100644 (file)
@@ -768,7 +768,6 @@ static struct page *kimage_alloc_page(struct kimage *image,
                                kimage_free_pages(old_page);
                                continue;
                        }
-                       addr = old_addr;
                        page = old_page;
                        break;
                }
@@ -788,7 +787,6 @@ static int kimage_load_normal_segment(struct kimage *image,
        unsigned char __user *buf = NULL;
        unsigned char *kbuf = NULL;
 
-       result = 0;
        if (image->file_mode)
                kbuf = segment->kbuf;
        else